New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to OpenCV 4.0.1 #7

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@MasashiYokota
Copy link

MasashiYokota commented Dec 23, 2018

Hi, I updated some Dockerfiles to the OpenCV 4.0.0.

I fixed the bulid-stage Dockerfile based on this commit of the gocv repository.
And, bacause some paths relevant to OpenCV 4.0.0 (e.g. package-config file name etc.) changed, I also fixed the runtime Dockerfile.

Although this patch works well in my project, please let me know if it still has some problem.
Thank you.

README.md Outdated
@@ -5,8 +5,8 @@
- Alpine 3.7
- FFMPEG 4.0
- Golang 1.10
- OpenCV 3.4.2
- OpenCV 3.4.2 contrib packages required by GoCV
- OpenCV 4.0.0

This comment has been minimized.

@pathouse

pathouse Jan 11, 2019

Contributor

probably want to update the version number in the header up on line 1 as well

COPY --from=build-stage /usr/local/include/opencv /usr/local/include/opencv
COPY --from=build-stage /usr/local/include/opencv2 /usr/local/include/opencv2
COPY --from=build-stage /usr/local/lib64/pkgconfig/opencv4.pc /usr/local/lib64/pkgconfig/opencv4.pc
COPY --from=build-stage /usr/local/include/opencv4/opencv2 /usr/local/include/opencv4/opencv2

This comment has been minimized.

@pathouse

pathouse Jan 11, 2019

Contributor

i found that i also needed to update some of the steps to get glibc down on lines 30-32

 wget -q -O /etc/apk/keys/sgerrand.rsa.pub https://alpine-pkgs.sgerrand.com/sgerrand.rsa.pub && \
 wget https://github.com/sgerrand/alpine-pkg-glibc/releases/download/2.28-r0/glibc-2.28-r0.apk && \
 apk add --no-cache  glibc-2.28-r0.apk && \

@MasashiYokota MasashiYokota changed the title Update Dockerfile to OpenCV 4.0.0 Update Dockerfile to OpenCV 4.0.1 Jan 13, 2019

@MasashiYokota

This comment has been minimized.

Copy link

MasashiYokota commented Jan 13, 2019

@pathouse
Thank you for your comments. I have fixed the README and Dockerfiles following your advises.
And, I also have updated the OpenCV as I found v4.0.1 was released.
Please check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment