New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mrbgems link error #324

Merged
merged 1 commit into from Sep 23, 2017

Conversation

Projects
None yet
2 participants
@syucream
Contributor

syucream commented Sep 22, 2017

Avoid link error to specify -lcrypto expricitlly by using NGX_MRUBY_LDFLAGS supported at ngx_mruby v1.20.1.
The no-sandbox option doesn't work for me. at #312 will be fixed.

Have you:

  • Followed the guidelines in our Contributing document?
  • Checked to ensure there aren't other open Pull Requests for the same update/change?
  • Run brew audit --strict --online <formula> (where <formula> is the name of the formula you're submitting) and corrected all errors?
  • Built your formula locally prior to submission with brew install <formula>?

New formula: have you

- [ ] Written a sensible test? (The best test is to compile and run a sample program.)

Updates to existing formula: have you

- [ ] Removed the revision line, if any, when bumping the version number?
- [ ] Added/bumped the revision number if the changes affect the precompiled bottles?

  • Not altered the bottle section?
  • Checked that the tests still pass?

@syucream syucream referenced this pull request Sep 22, 2017

Closed

Cannot install nginx-full --with-mruby-module #312

3 of 5 tasks complete
@syucream

This comment has been minimized.

Contributor

syucream commented Sep 22, 2017

CI build fails caused by out of my modification ... What should I do?

@denji denji merged commit 36d72bb into denji:master Sep 23, 2017

1 check failed

continuous-integration/jenkins/ghprb Build finished.
Details

@syucream syucream deleted the syucream:fix-ngx_mruby branch Sep 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment