Skip to content

Dennis Suratna
denniss

  • Joined on
@denniss
@denniss
@denniss
  • @denniss de391b3
    EMAIL_OPEN conversion type
denniss commented on issue rails/rails#22474
@denniss

What should the value of car.engine be AFTER calling car.build_engine when the newly built engine is invalid? Should it be the instance of the old …

denniss commented on issue rails/rails#22484
@denniss

@tilhoft Can you make your test fail (i.e. add some assertions)? Here's an example of a failing test: https://gist.github.com/jaredhoyt/c774c051ca…

denniss commented on issue rails/rails#22490
@denniss

Failing test require 'active_record' require 'minitest/autorun' require 'logger' begin require 'bundler/inline' rescue LoadError => e $stderr.puts 'B…

denniss commented on issue rails/rails#22474
@denniss

I may be repeating what's already been said here. So it looks like the current behavior creates a new engine and orphans the old engine record. ass…

denniss commented on issue rails/rails#22474
@denniss

Are you saying that there is already an engine record persisted before calling car.build_engine?

Something went wrong with that request. Please try again.