Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete signals in dsmr_consumption #63

Closed
dennissiemensma opened this issue Feb 29, 2016 · 1 comment
Closed

Obsolete signals in dsmr_consumption #63

dennissiemensma opened this issue Feb 29, 2016 · 1 comment
Assignees
@dennissiemensma
Milestone
0.15 (β)

Comments

@dennissiemensma
Copy link
Member

These signals are obsolete, Django emits them as well on model creation:

  • dsmr_consumption.signals.electricity_consumption_created.send_robust(None, instance=consumption)
  • dsmr_consumption.signals.gas_consumption_created.send_robust(None, instance=consumption)

They should be removed and phased out with all references along and replaced by:
django.db.models.signals.post_save
@dennissiemensma dennissiemensma modified the milestones: 1.1.0, 0.14 (β) Feb 29, 2016
@dennissiemensma dennissiemensma modified the milestones: 0.14 (β), 0.15 (β) Mar 14, 2016
@dennissiemensma dennissiemensma self-assigned this Mar 22, 2016
dennissiemensma added a commit that referenced this issue Mar 22, 2016
@dennissiemensma
Obsolete signals in dsmr_consumption #63
6106463
dennissiemensma added a commit that referenced this issue Mar 22, 2016
@dennissiemensma
Obsolete signals in dsmr_consumption #63
ca7a8ef
@dennissiemensma
Copy link
Member Author

Merged & deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dennissiemensma dennissiemensma

Labels
None yet
Projects
None yet
Milestone
0.15 (β)
Development

No branches or pull requests
1 participant
@dennissiemensma