This repository was archived by the owner on Jul 31, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 5
Multiple subapps can mount #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@talentlessguy should we move to regexparam? https://deno.land/x/regexparam@v2.0.1 I don't like the current regex. Regex is also partially the issue for #12 |
v1rtl
suggested changes
Jun 10, 2023
aarontravass
commented
Jun 11, 2023
| }) | ||
| }) | ||
| }) | ||
| describe('Network extensions', () => { |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was hanging so I commented it out
v1rtl
suggested changes
Jun 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14