Skip to content
Permalink
Browse files

Increase buffer size to 8mb to circumvent prettier loading problem

  • Loading branch information...
ry committed Mar 13, 2019
1 parent 3fd0286 commit 04c14d5b6cb36e4e11b8532dd7c8d5f0a10416a7
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/cli.rs
@@ -41,7 +41,7 @@ impl Cli {
state: Arc<IsolateState>,
permissions: DenoPermissions,
) -> Self {
let buffer = msg_ring::Buffer::new(1024 * 1024);
let buffer = msg_ring::Buffer::new(8 * 1024 * 1024);
let shared = buffer.into_deno_buf();
let (tx_buffer, rx_buffer) = buffer.split();
let (tx, _) = msg_ring::MsgRing::new(tx_buffer).split();

2 comments on commit 04c14d5

@hayd

This comment has been minimized.

Copy link
Contributor

hayd replied Mar 14, 2019

Is there any reason to choose 8mb over 64mb or even higher?

@ry

This comment has been minimized.

Copy link
Collaborator Author

ry replied Mar 14, 2019

This is a hack to just get some tests to pass - ultimately we shouldn't be bounded by the size of the shared buffer. Increasing it will increase memory usage. I'd rather keep it small so we continue to hit errors and I'll be forced to fashion a proper fix - if I make it big the errors will be more rare.

Please sign in to comment.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.