Skip to content

Commit e7b39eb

Browse files
authored
revert: type-check with native tsc by default (#37057)
Reverts #35938 to restore the in-process TypeScript checker for `deno check`, as the first step in rolling back the breaking TypeScript migration for compatible canary builds. This restores file-change rechecking under `--watch`, documentation snippet checking under `--doc`/`--doc-only`, and the previous diagnostics and spec expectations.
1 parent 6e9f66f commit e7b39eb

139 files changed

Lines changed: 292 additions & 2260 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/workflows/ci.generated.yml‎

Lines changed: 0 additions & 168 deletions
Large diffs are not rendered by default.

‎.github/workflows/ci.ts‎

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1442,38 +1442,6 @@ const buildJobs = buildItems.map((rawBuildItem) => {
14421442
key: "playwright-${{ runner.os }}-${{ runner.arch }}",
14431443
},
14441444
},
1445-
{
1446-
name: "Set up native tsc cache",
1447-
if: testCrateNameExpr.equals("integration").or(
1448-
testCrateNameExpr.equals("specs"),
1449-
),
1450-
uses: "actions/cache@v5",
1451-
with: {
1452-
// Keyed on native.rs so a pinned-version bump re-downloads.
1453-
path: "./target/.native_tsc",
1454-
key:
1455-
"tsc-${{ runner.os }}-${{ runner.arch }}-${{ hashFiles('cli/tsc/native.rs') }}",
1456-
},
1457-
},
1458-
{
1459-
// Warm the cache with the compiler `deno check` uses (into the
1460-
// default target/.native_tsc/deno_dir) so the test step doesn't
1461-
// re-download it for every test's fresh DENO_DIR. The harness
1462-
// resolves that path and injects DENO_TSC_BIN per-test itself (see
1463-
// test_util::native_tsc_bin_path); no env export needed. Run it with
1464-
// the built deno binary (the test job has no system `deno` on PATH).
1465-
name: "Pre-download native tsc",
1466-
if: testCrateNameExpr.equals("integration").or(
1467-
testCrateNameExpr.equals("specs"),
1468-
),
1469-
run: [
1470-
'DENO_BIN=""',
1471-
"for c in ./target/release/deno ./target/release/deno.exe ./target/debug/deno ./target/debug/deno.exe; do",
1472-
' [ -f "$c" ] && DENO_BIN="$c" && break',
1473-
"done",
1474-
'"$DENO_BIN" run -A ./tools/download_tsc.ts',
1475-
].join("\n"),
1476-
},
14771445
{
14781446
if: buildItem.os.equals("linux").and(
14791447
buildItem.arch.equals("aarch64"),

‎cli/graph_util.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1301,7 +1301,7 @@ impl ModuleGraphBuilder {
13011301
}
13021302
}
13031303

1304-
pub(crate) fn maybe_resolve_ts_config_imports(
1304+
fn maybe_resolve_ts_config_imports(
13051305
&self,
13061306
graph_kind: GraphKind,
13071307
) -> Vec<deno_graph::ReferrerImports> {

‎cli/lib.rs‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -240,12 +240,8 @@ async fn run_subcommand(
240240
tools::installer::ci_command(Arc::new(flags), ci_flags).await
241241
}),
242242
DenoSubcommand::SyncTypes(sync_types_flags) => spawn_subcommand(async {
243-
tools::installer::sync_types_command(
244-
Arc::new(flags),
245-
sync_types_flags,
246-
tools::installer::RootTsConfigMode::Always,
247-
)
248-
.await
243+
tools::installer::sync_types_command(Arc::new(flags), sync_types_flags)
244+
.await
249245
}),
250246
DenoSubcommand::JSONReference(json_reference) => {
251247
spawn_subcommand(async move {

0 commit comments

Comments
 (0)