Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Req/Sec benchmark is missing `node_http` #1907

Closed
zaynv opened this Issue Mar 11, 2019 · 4 comments

Comments

4 participants
@zaynv
Copy link

commented Mar 11, 2019

The req/sec benchmark mentions that:

deno is a fake http server that doesn't parse HTTP. It is comparable to node_tcp .
deno_net_http is a web server written in TypeScript. It is comparable to node_http .
hyper is a Rust HTTP server and represents an upper bound.

I was confused by this line:

deno_net_http is a web server written in TypeScript. It is comparable to node_http.

There doesn't seem to be a node_http in the graph, so what are we supposed to be comparing deno_net_http with?

@kevinkassimo

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

node: node HTTP
node_tcp: node TCP
deno: deno TCP
deno_net_http: deno using std/http/server.ts

The benchmark is not very satisfactory at this moment, but a major internal design update and performance boost is coming pretty soon (deno_core_single and deno_core_multi are experimental benchmarks for the pending new design)

@zaynv

This comment has been minimized.

Copy link
Author

commented Mar 11, 2019

Oh I see looking forward to seeing with new design. If I understand correctly node_http is referring to node in the graph? Thanks, and feel free to close this.

@bartlomieju

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2019

Can be closed CC @ry

@ry

This comment has been minimized.

Copy link
Collaborator

commented Apr 13, 2019

Thanks

@ry ry closed this Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.