Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PerformanceObserver.observe from node:perf_hooks #25034

Open
nicolo-ribaudo opened this issue Aug 14, 2024 · 1 comment
Open

Implement PerformanceObserver.observe from node:perf_hooks #25034

nicolo-ribaudo opened this issue Aug 14, 2024 · 1 comment
Labels
bug Something isn't working correctly node compat

Comments

@nicolo-ribaudo
Copy link

There has been recently an update in the grammardown npm package that makes ecmarkup not work anymore in Deno (I was trying in https://github.com/tc39/ecma262/):

deno run -A npm:ecmarkup --verbose spec.html --multipage out
error: Uncaught Error: Not implemented: PerformanceObserver.observe
    at notImplemented (ext:deno_node/_utils.ts:6:9)
    at PerformanceObserver.observe (node:perf_hooks:5:5)
    at reset (file:///home/nic/Documents/dev/github.com/tc39/ecma262/node_modules/.deno/grammarkdown@3.3.2/node_modules/grammarkdown/dist/performance.js:128:18)
    at Object.<anonymous> (file:///home/nic/Documents/dev/github.com/tc39/ecma262/node_modules/.deno/grammarkdown@3.3.2/node_modules/grammarkdown/dist/performance.js:88:1)
    at Object.<anonymous> (file:///home/nic/Documents/dev/github.com/tc39/ecma262/node_modules/.deno/grammarkdown@3.3.2/node_modules/grammarkdown/dist/performance.js:141:4)
    at Module._compile (node:module:659:34)
    at Object.Module._extensions..js (node:module:673:10)
    at Module.load (node:module:597:32)
    at Function.Module._load (node:module:484:12)
    at Module.require (node:module:609:19)

I saw that there is already #11260 open, but that one looks to be about the global web API that has the same name.

@nicolo-ribaudo
Copy link
Author

nicolo-ribaudo commented Aug 14, 2024

Actually, this didn't stop working due to a change in an npm package, but due to a change in Deno itself. deno run -A npm:ecmarkup --verbose spec.html --multipage out works when using Deno 1.41, and fails with 1.44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly node compat
Projects
None yet
Development

No branches or pull requests

2 participants