New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextEncoder and TextDecoder #470

Closed
ry opened this Issue Aug 7, 2018 · 0 comments

Comments

1 participant

@ry ry added this to the v0.1 (first binary release) milestone Aug 7, 2018

ry added a commit that referenced this issue Aug 7, 2018

ry added a commit that referenced this issue Aug 7, 2018

ry added a commit that referenced this issue Aug 7, 2018

Add TextEncoder/TextDecoder
Fixes #470

This commit increases exe size
out/release/deno  48M -> 52M

ry added a commit that referenced this issue Aug 7, 2018

Add TextEncoder/TextDecoder
Fixes #470

This commit increases exe size
out/release/deno  48M -> 52M

ry added a commit that referenced this issue Aug 8, 2018

Add TextEncoder/TextDecoder
Fixes #470

This commit increases exe size
out/release/deno  48M -> 52M

ry added a commit that referenced this issue Aug 8, 2018

Add TextEncoder/TextDecoder
Fixes #470

This commit increases exe size
out/release/deno  48M -> 52M

ry added a commit that referenced this issue Aug 8, 2018

Add TextEncoder/TextDecoder
Fixes #470

This commit increases exe size
out/release/deno  48M -> 52M

ry added a commit that referenced this issue Aug 8, 2018

Add TextEncoder/TextDecoder
Fixes #470

This commit increases exe size
out/release/deno  48M -> 52M

ry added a commit that referenced this issue Aug 8, 2018

Add TextEncoder/TextDecoder
Fixes #470

This commit increases exe size
out/release/deno  48M -> 52M

ry added a commit that referenced this issue Aug 8, 2018

Add TextEncoder/TextDecoder
Fixes #470

This commit increases exe size
out/release/deno  48M -> 52M

ry added a commit that referenced this issue Aug 8, 2018

Add TextEncoder/TextDecoder
Fixes #470

This commit increases exe size
out/release/deno  48M -> 54M

ry added a commit that referenced this issue Aug 9, 2018

Add TextEncoder/TextDecoder
Fixes #470

This commit increases exe size
out/release/deno  48M -> 52M

ry added a commit that referenced this issue Aug 9, 2018

Add TextEncoder/TextDecoder
Fixes #470

This commit increases exe size
out/release/deno  48M -> 52M

ry added a commit that referenced this issue Aug 9, 2018

Add TextEncoder/TextDecoder
Fixes #470

This commit increases exe size
out/release/deno  48M -> 52M

ry added a commit that referenced this issue Aug 9, 2018

Add TextEncoder/TextDecoder
Fixes #470

This commit increases exe size
out/release/deno  49M -> 53M

ry added a commit that referenced this issue Aug 9, 2018

Add TextEncoder/TextDecoder
Fixes #470

This commit increases exe size
out/release/deno  49M -> 53M

ry added a commit that referenced this issue Aug 9, 2018

Add ReadFileSync/TextEncoder/TextDecoder
Fixes #470

This commit increases exe size
out/release/deno  49M -> 53M

ry added a commit that referenced this issue Aug 9, 2018

Add TextEncoder/TextDecoder support.
Fixes #470

This commit increases size:
out/release/gen/bundle/main.js      7.3M -> 7.9M
out/release/gen/bundle/main.js.map   11M -> 12M
out/release/gen/snapshot_deno.bin    34M -> 37M
out/release/deno                     49M -> 53M

Note the amount in the JS code added is quite small:
4.0K    node_modules/text-encoding/index.js
4.0K    node_modules/@types/text-encoding/index.d.ts
4.0K    js/text_encoding.ts

Unclear to me what is causing the jump in snapshot size.

ry added a commit that referenced this issue Aug 9, 2018

Add TextEncoder/TextDecoder support.
Fixes #470

This commit increases size:
out/release/gen/bundle/main.js      7.3M -> 7.9M
out/release/gen/bundle/main.js.map   11M -> 12M
out/release/gen/snapshot_deno.bin    34M -> 37M
out/release/deno                     49M -> 53M

Note the amount in the JS code added is quite small:
4.0K    node_modules/text-encoding/index.js
4.0K    node_modules/@types/text-encoding/index.d.ts
4.0K    js/text_encoding.ts

Unclear to me what is causing the jump in snapshot size.

@ry ry closed this in 040a042 Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment