Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileReader API missing #5249

Closed
brianleroux opened this issue May 12, 2020 · 12 comments
Closed

FileReader API missing #5249

brianleroux opened this issue May 12, 2020 · 12 comments
Labels

Comments

@brianleroux
Copy link

@brianleroux brianleroux commented May 12, 2020

The browser global FileReader is missing which is in use by many popular modules such as the aws-sdk by AWS.

@ry ry added the feat label May 12, 2020
@ry
Copy link
Member

@ry ry commented May 12, 2020

Hey Brian :)

I definitely want to get aws-sdk ported - that would be awesome.

@brianleroux
Copy link
Author

@brianleroux brianleroux commented May 12, 2020

Meeee too. I think we will have an S3 client shortly here anyhow. The community DynamoDB client is excellent starting point. And once we have SNS and SQS…I won't have a use case for Node anymore.

@jimmywarting
Copy link

@jimmywarting jimmywarting commented May 12, 2020

Thinking we don't need another way of reading files when .text(), .arrayBuffer() & .stream() already exist

Kinda the new way of reading blob's in browser now days

#4581

@crowlKats
Copy link
Contributor

@crowlKats crowlKats commented May 12, 2020

well aws-sdk and others use FileReader

@jimmywarting
Copy link

@jimmywarting jimmywarting commented May 12, 2020

feels like the FileReader will become more obsolete when ppl switch to the new methods

@ashx404
Copy link

@ashx404 ashx404 commented May 12, 2020

But it'll take time for them to become obsolete.

@kitsonk
Copy link
Contributor

@kitsonk kitsonk commented May 12, 2020

We have always supported standard browser APIs based on a compelling feature request and complexity of implementing, versus whether there are better ways to do it. Supporting aws-sdk is a very compelling use case.

@PaulThompson
Copy link
Contributor

@PaulThompson PaulThompson commented Jun 28, 2020

I had an attempt at the aws-sdk
aws/aws-sdk-js-v3#1289

@PaulThompson
Copy link
Contributor

@PaulThompson PaulThompson commented Jul 7, 2020

I made a start on FileReader https://github.com/PaulThompson/deno/tree/feat-filereader

@PaulThompson
Copy link
Contributor

@PaulThompson PaulThompson commented Jul 25, 2020

Ready for review on #6673

@bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Aug 11, 2020

Done in #6673, will be released in v1.3.0 on Thursday.

CC @brianleroux

@lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Aug 11, 2020

Meeee too. I think we will have an S3 client shortly here anyhow. The community DynamoDB client is excellent starting point. And once we have SNS and SQS…I won't have a use case for Node anymore.

@brianleroux FYI I started work on a S3 and SQS client a while ago. Not fully featured yet, but it is a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
You can’t perform that action at this time.