New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some test cases are being skipped in CI? #888

Closed
kt3k opened this Issue Oct 3, 2018 · 5 comments

Comments

3 participants
@kt3k
Copy link
Contributor

kt3k commented Oct 3, 2018

Starting from this build https://travis-ci.com/denoland/deno/jobs/147902463, the log output of test cases in CI seems incomplete. (The unit tests seem stopping in the middle without error.)


update:
When I set DENO_BUILD_MODE=release, the same thing happens on my local machine (mac).

@kevinkassimo

This comment has been minimized.

Copy link
Contributor

kevinkassimo commented Oct 3, 2018

Same thing happened to me. Seems that most async tests are dead.

This is pretty bad.

@kevinkassimo

This comment has been minimized.

Copy link
Contributor

kevinkassimo commented Oct 5, 2018

An interesting discovery (purely by luck): by introducing debug!(...) statements in ntasks_increment and ntasks_decrement, I was able to allow tests to run normally again without skipping... @piscisaureus I believe you mentioned about a Rust compiler bug before? This seems unexpectedly mitigates the issue on my machine...

@ry

This comment has been minimized.

Copy link
Collaborator

ry commented Oct 5, 2018

It seems we have some sort of memory corruption happening - somewhere. I haven’t experienced it yet but we need to correct it.

Chrome has all sorts of memory check tools
https://www.chromium.org/developers/testing/addresssanitizer
https://www.chromium.org/developers/testing/memorysanitizer
It shouldn’t be too much work to hook into these - I think it could be helpful debugging this issue.

See also this recent commit 97e08a6

@ry

This comment has been minimized.

Copy link
Collaborator

ry commented Oct 5, 2018

Related fix: cfa54ca

@kt3k

This comment has been minimized.

Copy link
Contributor Author

kt3k commented Oct 7, 2018

Now all test cases seem passing in CI. Thanks for the fixes!

@kt3k kt3k closed this Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment