Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno cache breaks on redirected libraries. #9129

Closed
xReveres opened this issue Jan 15, 2021 · 5 comments · Fixed by #9287
Closed

Deno cache breaks on redirected libraries. #9129

xReveres opened this issue Jan 15, 2021 · 5 comments · Fixed by #9287
Assignees
Labels
bug Something isn't working cli related to cli/ dir

Comments

@xReveres
Copy link

xReveres commented Jan 15, 2021

Today I wanted to implement this library:
https://deno.land/x/hmac@v1.0.2
But the problem is that, deno tries recompile whole project every time.
After day of test I found that this library imports own deps.ts with own third party libraries for example:
https://denopkg.com/chiefbiiko/sha1@v1.0.3/mod.ts
If we go under this address, we are redirected to:
https://raw.githubusercontent.com/chiefbiiko/sha1/v1.0.3/mod.ts
In $HOME/.cache/deps directory I see denopkg.com and raw.githubusercontent.com directories, so I don't know if this is a deno or denopkg problem.

Steps to reproduce:

  1. Create test.ts file
  2. Inside put:
import * as test from 'https://denopkg.com/chiefbiiko/sha1@v1.0.3/mod.ts'
  1. deno run test.ts
@lucacasonato
Copy link
Member

cc @kitsonk

@xReveres
Copy link
Author

On Deno 1.6.1 looks good, file is not compiling every time

@lucacasonato
Copy link
Member

@xReveres Does this succeed in 1.6.3?

@xReveres
Copy link
Author

@lucacasonato Sorry. I'm forgot add information about Deno version in main post. No, from my tests, this "bug"? exists only on Deno v1.6.2 and v1.6.3.

@PaulThompson
Copy link
Contributor

This issue exists on code I wrote that also uses denopkg for importing some dependencies from github.
Checked your test case just now on 1.7.0 - still with behaviour that it runs the typescript compile/checks on each call to deno run test.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli related to cli/ dir
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants