New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(webapp): improve performance of benchmark page and fix test #1002

Merged
merged 1 commit into from Oct 16, 2018

Conversation

2 participants
@kt3k
Copy link
Contributor

kt3k commented Oct 16, 2018

The script in benchmark page now fetches 2 APIs sequentially. This PR changes it to load them in parallel.

And this PR also fixes the test case of getTravisData (//webapp/app.js) by using the mock API data.

const data = await getTravisData(
"http://localhost:4545/tools/testdata/travis_benchmark.json"
);
assert(data.length !== 0);

This comment has been minimized.

@ry

ry Oct 16, 2018

Collaborator

nice!

@ry

ry approved these changes Oct 16, 2018

Copy link
Collaborator

ry left a comment

LGTM - thanks!

@ry ry merged commit d4afbe6 into denoland:master Oct 16, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment