New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: store last-modified timestamps in Github Actions cache #10110
Conversation
af03846
to
d427d01
Compare
cf69b1d
to
58ac462
Compare
Although it does help to make builds a little bit faster, the speedup on no-op builds is rather misleading. It is worth noting that that tiny change does trigger 15 rustc invocations, 11 of which get LTO optimized to the bone - that's "only" 3-4 minutes per target. This is what we really need to deal with; IMO only deno.exe and denort.exe really need aggressive optimization, for the other targets we should probably turn LTO off and consider -O1. This is what runs on linux (reordered/grouped for clarity):
|
58ac462
to
0cb4001
Compare
This reverts commit fd65e6d.
0cb4001
to
bed35c6
Compare
This reverts commit fd65e6d.
bed35c6
to
8912a90
Compare
8912a90
to
af35aad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I also tested in this run https://github.com/denoland/deno/runs/2317951107
The added
and stale
counts look correct in bench job, and build time is shorter than full build (right items seem being rebuilt in log)
break; | ||
default: { | ||
// Regular file. | ||
const key = [mode, hash, eol, path].join("\0"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this key does the trick 👍
This reverts commit fd65e6d.
af35aad
to
06b5959
Compare
No description provided.