Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Rust to 1.55.0 #11965

Merged
merged 3 commits into from Sep 10, 2021
Merged

chore: upgrade Rust to 1.55.0 #11965

merged 3 commits into from Sep 10, 2021

Conversation

magurotuna
Copy link
Member

No description provided.

@@ -60,7 +60,7 @@ fn get_io_error_class(error: &io::Error) -> &'static str {
WouldBlock => unreachable!(),
// Non-exhaustive enum - might add new variants
// in the future
_ => unreachable!(),
_ => "Error",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://blog.rust-lang.org/2021/09/09/Rust-1.55.0.html#stdioerrorkind-variants-updated

Since 1.55.0, errors that were previously ErrorKind::Other have been changed to ErrorKind::Uncategorized. To match the Uncategorized we have to use wildcard pattern.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ry ry merged commit 8705292 into denoland:main Sep 10, 2021
@magurotuna magurotuna deleted the rust-1-55 branch September 11, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants