fix(testing): do not throw on error.errors.map #12810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
requested changes
Nov 19, 2021
There was a problem hiding this comment.
Thanks for this patch @yacinehmito! I think we just need to check for error being an AggregateError or possibly that error.errors instanceof Array
yacinehmito
force-pushed
the
fix-error-errors-map
branch
2 times, most recently
from
2609ad2
to
878a066
Compare
|
Thank you for the review @dsherret. |
In tests, the function to format errors would assume that any error with a property `errors` would be an `AggregateError`, and therefore the property `errors` would contain an error. This is not necessarily the case.
yacinehmito
force-pushed
the
fix-error-errors-map
branch
from
878a066
to
9002c80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tests, the function to format errors would assume that any property
errorson error would contain an array, which is not necessarily the case.I am currently porting a library to Deno and I was just bit by this.