Add more console types formatting support #1299

kevinkassimo · 2018-12-10T03:16:50Z

Noticed that we haven't yet support types such as Map when I was doing some debugging (which is annoying...).

This PR adds formatting support to the following types:

Set/Map
WeakSet/WeakMap (WeakMap { [items unknown] }, similar behavior to Node)
Wrapper objects (Number/Boolean/String)
Date
RegExp
TypedArray (Uint8Array etc.)

Changed:

DEFAULT_MAX_DEPTH for nested object printing is increased to 4 (2 is too restrictive)
[object] => [Object] for deeply nested objects (as seen in Node)
[object] => [Set]/[Map] etc. for deeply nested Set/Map (as seen in Node)

kevinkassimo · 2018-12-10T03:28:01Z

I am seeing errors about deno_net on AppVeyor again:

error: Server does not allow request for unadvertised object 958dadc8752f1aface8cff39c56011b016fb1460
Fetched in submodule path 'js/deps/https/deno.land/x/net', but it did not contain 958dadc8752f1aface8cff39c56011b016fb1460. Direct fetching of that commit failed.

kyranet · 2018-12-10T08:08:39Z

js/console.ts

-const DEFAULT_MAX_DEPTH = 2;
+const DEFAULT_MAX_DEPTH = 4;
+
+const TYPEDARRAY_TYPES = [


I saw somewhere in another commit of deno use TypedArray, which can be exposed by doing Object.getPrototypeof(Int8Array), which all typed arrays extend. It's shorter and provides support for BigInt64Array and BigUint64Array, which the version of V8 we use supports, and possibly any other typed array that gets implemented in the future.

Found it! It's in util.ts, we could use this function instead of running a loop for each typed array:

deno/js/util.ts

Lines 129 to 133 in c427c2d

// tslint:disable-next-line:variable-name

const TypedArrayConstructor = Object.getPrototypeOf(Uint8Array);

export function isTypedArray(x: unknown): x is TypedArray {

return x instanceof TypedArrayConstructor;

}

Great! Thanks for the suggestion. Will update right away

(Did not notice that I should import TypedArray from types.ts)

Yeah, that too 👍

js/console.ts

kyranet

Other than this, it looks LGTM

kyranet · 2018-12-10T09:09:21Z

js/console.ts

+    return createWeakSetString();
+  } else if (value instanceof WeakMap) {
+    return createWeakMapString();
+  } else {


The next line could be inlined for consistency with the other conditions, using else if, and createRawObjectString inside the else.

Oh yeah... (I was too tired and totally ignored this...)

ry · 2018-12-10T16:39:39Z

@kevinkassimo

error: Server does not allow request for unadvertised object

Thanks for the notice. Should be fixed now. It's because git submodules requires the linked revision to be published as the head of a branch (?). I'll think about how to deal with this in the future.

ry

LGTM - thanks!

- console.assert should not throw error (denoland#1335) - Support more modes in deno.open (denoland#1282, denoland#1336) - Simplify code fetch logic (denoland#1322) - readDir entry mode (denoland#1326) - Use stderr for exceptions (denoland#1303) - console.log formatting improvements (denoland#1327, denoland#1299) - Expose TooLarge error code for buffers (denoland#1298)

- console.assert should not throw error (#1335) - Support more modes in deno.open (#1282, #1336) - Simplify code fetch logic (#1322) - readDir entry mode (#1326) - Use stderr for exceptions (#1303) - console.log formatting improvements (#1327, #1299) - Expose TooLarge error code for buffers (#1298)

Add more console types formatting support

bcc1b14

kevinkassimo force-pushed the console/more-types branch from f0fedea to bcc1b14 Compare December 10, 2018 03:26

kyranet reviewed Dec 10, 2018

View reviewed changes

kevinkassimo force-pushed the console/more-types branch from 7b4a368 to b650506 Compare December 10, 2018 09:15

Use isTypedArray

a4f38ec

kevinkassimo force-pushed the console/more-types branch from b650506 to a4f38ec Compare December 10, 2018 09:19

ry approved these changes Dec 10, 2018

View reviewed changes

ry merged commit 1548792 into denoland:master Dec 10, 2018

ry mentioned this pull request Dec 14, 2018

v0.2.3 #1353

Merged

kevinkassimo deleted the console/more-types branch December 27, 2019 07:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more console types formatting support #1299

Add more console types formatting support #1299

kevinkassimo commented Dec 10, 2018 •

edited

kevinkassimo commented Dec 10, 2018 •

edited

kyranet Dec 10, 2018

kyranet Dec 10, 2018

kevinkassimo Dec 10, 2018 •

edited

kyranet Dec 10, 2018

kyranet left a comment

kyranet Dec 10, 2018

kevinkassimo Dec 10, 2018

ry commented Dec 10, 2018

ry left a comment

	// tslint:disable-next-line:variable-name
	const TypedArrayConstructor = Object.getPrototypeOf(Uint8Array);
	export function isTypedArray(x: unknown): x is TypedArray {
	return x instanceof TypedArrayConstructor;
	}

Add more console types formatting support #1299

Add more console types formatting support #1299

Conversation

kevinkassimo commented Dec 10, 2018 • edited

kevinkassimo commented Dec 10, 2018 • edited

kyranet Dec 10, 2018

Choose a reason for hiding this comment

kyranet Dec 10, 2018

Choose a reason for hiding this comment

kevinkassimo Dec 10, 2018 • edited

Choose a reason for hiding this comment

kyranet Dec 10, 2018

Choose a reason for hiding this comment

kyranet left a comment

Choose a reason for hiding this comment

kyranet Dec 10, 2018

Choose a reason for hiding this comment

kevinkassimo Dec 10, 2018

Choose a reason for hiding this comment

ry commented Dec 10, 2018

ry left a comment

Choose a reason for hiding this comment

kevinkassimo commented Dec 10, 2018 •

edited

kevinkassimo commented Dec 10, 2018 •

edited

kevinkassimo Dec 10, 2018 •

edited