New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assertion for empty modules #1450

Merged
merged 2 commits into from Jan 4, 2019

Conversation

2 participants
@satyarohith
Copy link
Contributor

satyarohith commented Jan 3, 2019

closes #1448

@ry
Copy link
Collaborator

ry left a comment

Can we get a test?

@satyarohith

This comment has been minimized.

Copy link
Contributor

satyarohith commented Jan 4, 2019

@ry added test :)

@ry

ry approved these changes Jan 4, 2019

Copy link
Collaborator

ry left a comment

Cool LGTM

@ry ry merged commit 6be1164 into denoland:master Jan 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@satyarohith satyarohith deleted the satyarohith:empty-file branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment