Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/http) nextRequest return type annotation from ResponseEvent to RequestEvent #15100

Merged
merged 1 commit into from Jul 7, 2022
Merged

fix(ext/http) nextRequest return type annotation from ResponseEvent to RequestEvent #15100

merged 1 commit into from Jul 7, 2022

Conversation

zachauten
Copy link
Contributor

Fixes #15099

ry
ry approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 82f7dae into denoland:main Jul 7, 2022
cjihrig pushed a commit that referenced this pull request Jul 12, 2022
@zachauten @cjihrig
fix(ext/http) nextRequest return type annotation from ResponseEvent t…
b1d7bd6 
…o RequestEvent (#15100)

Fixes #15099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong type annotation in 01_http.js
2 participants
@zachauten @ry