Chore: Added onbeforeunload to window type definition + updated test #16251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bartlomieju
approved these changes
Oct 13, 2022
|
I'm super stoked about having this merged! Thank you, @bartlomieju! |
bartlomieju
pushed a commit
that referenced
this pull request
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing with Deno a bit recently (since becoming FUNemployed as a result of layoff) 🥳
In playing around with globalThis and event handlers/listener, I noticed that onbeforeunload wasn't present on the window type definition, resulting in the following warning:
Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.deno-ts(7017)The observation is discussed a bit more here in this somewhat related thread: #13390
I figured this presented me with an opportunity to learn a bit more about Deno, so I set out to address this by updating the typings to include onbeforeunload.
Additionally, I've updated the onload integration test to the update update.
Please let me know if I've missed anything.
Thanks!
-Matt