fix(npm): use an http client with connection pool #16705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billywhizz
reviewed
Nov 18, 2022
| result_headers.insert(key_str, values_str); | ||
| } | ||
|
|
||
| if response.status().is_redirection() { |
There was a problem hiding this comment.
wondering do we need a check here for a redirect loop, i.e. throw an error if the "Location" is same as current? can raise a separate issue if so. a limit on depth of redirects would be good also. maybe this is handled elsewhere?
There was a problem hiding this comment.
It seems there is a redirect limit at a higher level in file_fetcher.rs. I'm not super familiar with this code... this diff is pretty terrible for some reason, but all I did was indent the fetch_once function into a method.
billywhizz
approved these changes
Nov 18, 2022
bartlomieju
approved these changes
Nov 18, 2022
bartlomieju
pushed a commit
that referenced
this pull request
Nov 24, 2022
Should make downloading npm packages faster and more reliable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make downloading npm packages faster and more reliable.