New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebAssembly to runtime library #1677

Merged
merged 1 commit into from Feb 5, 2019

Conversation

4 participants
@kitsonk
Copy link
Contributor

kitsonk commented Feb 5, 2019

This also modifies the ts_library_builder to support inlining assets.

We are going to have to manage this slightly different way than other items, because it isn't describing something we are adding to the runtime, it is describing something that is already there. In all other cases that is something we have leveraged the libs that come with TypeScript. We could include the @types but it would be a pain in the long term. I hope that TypeScript re-adds these as a lib since they have broad browser support now. The previous issue at TypeScript was closed based on it being experimental.

cc/ @ry @sh7dm

@ry
Copy link
Collaborator

ry left a comment

Very nice!
Can you include the integration test for wasm from #1675? (Probably just the typescript one is tests/wasm.ts.test is sufficient)

@ry ry referenced this pull request Feb 5, 2019

Closed

Add types for WebAssembly #1675

@sh7dm
Copy link
Contributor

sh7dm left a comment

As @ry said, it'll be good to add integration test, only TS, I've added both because I wanted to demonstrate that WASM works, but hasn't got type defs, so in this we just need a ts one. I can help

Add WebAssembly to runtime library
This also modifies the `ts_library_builder` to support inlining assets.

Includes integration tests from @sh7dm

@kitsonk kitsonk force-pushed the kitsonk:web-assembly branch from 95b6b5d to 36111d8 Feb 5, 2019

@sh7dm

sh7dm approved these changes Feb 5, 2019

Copy link
Contributor

sh7dm left a comment

LGTM, thanks for adding my test!

@daynin

daynin approved these changes Feb 5, 2019

@ry

ry approved these changes Feb 5, 2019

Copy link
Collaborator

ry left a comment

LGTM - thanks!

assert(targetSourceFile.getNamespace("Qat") != null);
const qatNamespace = targetSourceFile.getNamespaceOrThrow("Qat");
assert(qatNamespace.getClass("Foo") != null);
});

This comment has been minimized.

@ry

ry Feb 5, 2019

Collaborator

👍

@ry ry merged commit 48fedee into denoland:master Feb 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

ry added a commit to ry/deno that referenced this pull request Feb 9, 2019

v0.2.11
- Add deps to --info output (denoland#1720)
- Add --allow-read (denoland#1689)
- Add deno.isTTY() (denoland#1622)
- Add emojis to permission prompts (denoland#1684)
- Add basic WebAssembly support (denoland#1677)
- Add `NO_COLOR` support https://no-color.org/ (denoland#1716)
- Add color exceptions (denoland#1698)
- Fix: do not load cache files when recompile flag is set (denoland#1695)
- Upgrade V8 to 7.4.98 (denoland#1640)

ry added a commit that referenced this pull request Feb 9, 2019

v0.2.11
- Add deps to --info output (#1720)
- Add --allow-read (#1689)
- Add deno.isTTY() (#1622)
- Add emojis to permission prompts (#1684)
- Add basic WebAssembly support (#1677)
- Add `NO_COLOR` support https://no-color.org/ (#1716)
- Add color exceptions (#1698)
- Fix: do not load cache files when recompile flag is set (#1695)
- Upgrade V8 to 7.4.98 (#1640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment