New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emojis to permission prompts #1684

Merged
merged 2 commits into from Feb 7, 2019

Conversation

4 participants
@sh7dm
Copy link
Contributor

sh7dm commented Feb 5, 2019

Reason: #1651. I think it looks much better now

@sh7dm

This comment has been minimized.

Copy link
Contributor Author

sh7dm commented Feb 5, 2019

I'll add emojis to other output strings too, but not too many.

Show resolved Hide resolved src/permissions.rs Outdated
Show resolved Hide resolved src/permissions.rs Outdated
@sh7dm

This comment has been minimized.

Copy link
Contributor Author

sh7dm commented Feb 5, 2019

@daynin fixed! Thanks for a good advice.

@ry
Copy link
Collaborator

ry left a comment

Thanks -

Please use ⚠️... and no need to use a different one for each permission

It would be nice to make the text bold too... I think we could use
https://github.com/ogham/rust-ansi-term/blob/master/Cargo.toml
Or maybe it's easier just to write our own color module by porting this:
https://github.com/denoland/deno_std/blob/master/colors/mod.ts

@sh7dm

This comment has been minimized.

Copy link
Contributor Author

sh7dm commented Feb 5, 2019

@ry I think each emoji should say what is required, not just ⚠️

@ry

This comment has been minimized.

Copy link
Collaborator

ry commented Feb 5, 2019

I disagree. The purpose of the emoji is just to distinguish an important message from other logging output - we should be consistent and minimal in applying these. This is not going to be one of these projects that splatters the screen with undiscerning graphics.

@sh7dm

This comment has been minimized.

Copy link
Contributor Author

sh7dm commented Feb 5, 2019

@ry done! But after adding the ansi_term crate python tools/build.py stopped working, but cargo build didn't.

Show resolved Hide resolved src/permissions.rs Outdated
Show resolved Hide resolved src/permissions.rs Outdated
Show resolved Hide resolved src/permissions.rs Outdated

@ry ry requested a review from piscisaureus Feb 5, 2019

@ry

This comment has been minimized.

Copy link
Collaborator

ry commented Feb 5, 2019

@piscisaureus Please review for windows

Show resolved Hide resolved src/permissions.rs Outdated
Show resolved Hide resolved src/permissions.rs Outdated
Show resolved Hide resolved src/main.rs Outdated
Show resolved Hide resolved src/main.rs Outdated
@piscisaureus

This comment has been minimized.

Copy link
Collaborator

piscisaureus commented Feb 6, 2019

windows output visually looks like:

D:\deno>target\debug\deno.exe tools\format.ts
Compiling D:/deno/tools/format.ts
Compiling D:/deno/js/deps/https/deno.land/x/std/fs/path.ts
Compiling D:/deno/js/deps/https/deno.land/x/std/fs/path/mod.ts
Compiling D:/deno/js/deps/https/deno.land/x/std/fs/path/constants.ts
Compiling D:/deno/tools/util.ts
clang_format
�[1m�  Deno requests access to run a subprocess. Grant? [yN] �[0m
@sh7dm

This comment has been minimized.

Copy link
Contributor Author

sh7dm commented Feb 6, 2019

@piscisaureus are you in PowerShell or cmd?

@piscisaureus

This comment has been minimized.

Copy link
Collaborator

piscisaureus commented Feb 6, 2019

@sh7dm cmd. But I don't think that matters.

@piscisaureus

This comment has been minimized.

Copy link
Collaborator

piscisaureus commented Feb 6, 2019

PS D:\deno> .\target\debug\deno .\tools\format.ts
clang_format
�[1m�  Deno requests access to run a subprocess. Grant? [yN] �[0m
@ry

This comment has been minimized.

Copy link
Collaborator

ry commented Feb 6, 2019

revert the last commit to make it work on windows....

Use #[cfg(windows)] above the line.

@ry ry force-pushed the sh7dm:permission-emoji branch from fbb2724 to 7d972a2 Feb 6, 2019

@ry

This comment has been minimized.

Copy link
Collaborator

ry commented Feb 7, 2019

@piscisaureus please try again

@ry ry referenced this pull request Feb 7, 2019

Merged

Color exceptions #1698

@ry ry force-pushed the sh7dm:permission-emoji branch from 7d972a2 to d1a0906 Feb 7, 2019

@ry

ry approved these changes Feb 7, 2019

Copy link
Collaborator

ry left a comment

LGTM - nice work!

@ry ry merged commit 5c50d28 into denoland:master Feb 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@sh7dm sh7dm deleted the sh7dm:permission-emoji branch Feb 8, 2019

ry added a commit to ry/deno that referenced this pull request Feb 9, 2019

v0.2.11
- Add deps to --info output (denoland#1720)
- Add --allow-read (denoland#1689)
- Add deno.isTTY() (denoland#1622)
- Add emojis to permission prompts (denoland#1684)
- Add basic WebAssembly support (denoland#1677)
- Add `NO_COLOR` support https://no-color.org/ (denoland#1716)
- Add color exceptions (denoland#1698)
- Fix: do not load cache files when recompile flag is set (denoland#1695)
- Upgrade V8 to 7.4.98 (denoland#1640)

ry added a commit that referenced this pull request Feb 9, 2019

v0.2.11
- Add deps to --info output (#1720)
- Add --allow-read (#1689)
- Add deno.isTTY() (#1622)
- Add emojis to permission prompts (#1684)
- Add basic WebAssembly support (#1677)
- Add `NO_COLOR` support https://no-color.org/ (#1716)
- Add color exceptions (#1698)
- Fix: do not load cache files when recompile flag is set (#1695)
- Upgrade V8 to 7.4.98 (#1640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment