Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd emojis to permission prompts #1684
Conversation
This comment has been minimized.
This comment has been minimized.
I'll add emojis to other output strings too, but not too many. |
daynin
reviewed
Feb 5, 2019
src/permissions.rs Outdated
src/permissions.rs Outdated
This comment has been minimized.
This comment has been minimized.
@daynin fixed! Thanks for a good advice. |
ry
reviewed
Feb 5, 2019
Thanks - Please use It would be nice to make the text bold too... I think we could use |
This comment has been minimized.
This comment has been minimized.
@ry I think each emoji should say what is required, not just |
This comment has been minimized.
This comment has been minimized.
I disagree. The purpose of the emoji is just to distinguish an important message from other logging output - we should be consistent and minimal in applying these. This is not going to be one of these projects that splatters the screen with undiscerning graphics. |
This comment has been minimized.
This comment has been minimized.
@ry done! But after adding the |
ry
reviewed
Feb 5, 2019
src/permissions.rs Outdated
ry
reviewed
Feb 5, 2019
src/permissions.rs Outdated
ry
reviewed
Feb 5, 2019
src/permissions.rs Outdated
ry
requested a review
from
piscisaureus
Feb 5, 2019
This comment has been minimized.
This comment has been minimized.
@piscisaureus Please review for windows |
ry
reviewed
Feb 5, 2019
src/permissions.rs Outdated
ry
reviewed
Feb 5, 2019
src/permissions.rs Outdated
ry
reviewed
Feb 5, 2019
src/main.rs Outdated
piscisaureus
reviewed
Feb 6, 2019
src/main.rs Outdated
This comment has been minimized.
This comment has been minimized.
windows output visually looks like:
|
This comment has been minimized.
This comment has been minimized.
@piscisaureus are you in PowerShell or cmd? |
This comment has been minimized.
This comment has been minimized.
@sh7dm cmd. But I don't think that matters. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
revert the last commit to make it work on windows.... Use #[cfg(windows)] above the line. |
ry
force-pushed the
sh7dm:permission-emoji
branch
from
fbb2724
to
7d972a2
Feb 6, 2019
This comment has been minimized.
This comment has been minimized.
@piscisaureus please try again |
sh7dm commentedFeb 5, 2019
Reason: #1651. I think it looks much better now