New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deps to --info output. #1720

Merged
merged 3 commits into from Feb 9, 2019

Conversation

2 participants
@ry
Copy link
Collaborator

ry commented Feb 8, 2019

Move module stuff into its own file.
cc @kevinkassimo

@ry ry requested a review from piscisaureus Feb 9, 2019

@ry ry force-pushed the ry:deps branch from 65776b1 to b928744 Feb 9, 2019

Add deps to --info output.
Move module stuff into its own file.

@ry ry force-pushed the ry:deps branch from b928744 to fc05dfc Feb 9, 2019

Show resolved Hide resolved src/modules.rs Outdated
Show resolved Hide resolved src/modules.rs Outdated
@piscisaureus
Copy link
Collaborator

piscisaureus left a comment

LGTM for the first pass.
That said, I find the tree formatting very barebones to the point where the output is hard to interpret. I would suggest opening an issue that calls for improvement.

impl fmt::Display for Deps {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
for _i in 0..self.depth {
write!(f, "| ")?;

This comment has been minimized.

@piscisaureus

piscisaureus Feb 9, 2019

Collaborator

This bar | is not helpful IMO.

This comment has been minimized.

@ry

ry Feb 9, 2019

Author Collaborator

Very open to reformatting

This comment has been minimized.

@piscisaureus

piscisaureus Feb 9, 2019

Collaborator

Barebones:

root
  aaa
    alpha
      first
      second
    beta
      foo
      bar
  bbb
    something

Basic:

root
- aaa
  * alpha
    - first
    - second
  * bbb
    - foo
    - bar
- bbb
  * something

Advanced:

root
├─ aaa
│  ├─ alpha
│  │  ├─ first
│  │  └─ second
│  └─ bbb
│     ├─ foo
│     └─ bar
└─ bbb
   └─ something

This comment has been minimized.

@ry

ry Feb 9, 2019

Author Collaborator

"advanced" looks fine

@ry ry merged commit 99ce807 into denoland:master Feb 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@ry ry deleted the ry:deps branch Feb 9, 2019

ry added a commit to ry/deno that referenced this pull request Feb 9, 2019

v0.2.11
- Add deps to --info output (denoland#1720)
- Add --allow-read (denoland#1689)
- Add deno.isTTY() (denoland#1622)
- Add emojis to permission prompts (denoland#1684)
- Add basic WebAssembly support (denoland#1677)
- Add `NO_COLOR` support https://no-color.org/ (denoland#1716)
- Add color exceptions (denoland#1698)
- Fix: do not load cache files when recompile flag is set (denoland#1695)
- Upgrade V8 to 7.4.98 (denoland#1640)

ry added a commit that referenced this pull request Feb 9, 2019

v0.2.11
- Add deps to --info output (#1720)
- Add --allow-read (#1689)
- Add deno.isTTY() (#1622)
- Add emojis to permission prompts (#1684)
- Add basic WebAssembly support (#1677)
- Add `NO_COLOR` support https://no-color.org/ (#1716)
- Add color exceptions (#1698)
- Fix: do not load cache files when recompile flag is set (#1695)
- Upgrade V8 to 7.4.98 (#1640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment