fix(permissions): lock stdio streams when prompt is shown #17392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
Jan 13, 2023
| @@ -238,6 +243,9 @@ impl PermissionPrompter for TtyPrompter { | |||
| }; | |||
| }; | |||
|
|
|||
| drop(_stdout_guard); | |||
| drop(_stderr_guard); | |||
There was a problem hiding this comment.
We probably should remove the underscore prefixes when using an explicit drop.
dsherret
pushed a commit
that referenced
this pull request
Jan 13, 2023
This commit changes permission prompt to lock stdio streams when prompt is shown.
dsherret
pushed a commit
that referenced
this pull request
Jan 13, 2023
This commit changes permission prompt to lock stdio streams when prompt is shown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes permission prompt to lock stdio streams when prompt
is shown.