Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execPath function #1743

Merged
merged 2 commits into from Feb 15, 2019

Conversation

5 participants
@sh7dm
Copy link
Contributor

sh7dm commented Feb 11, 2019

Fixes #1723
TODO:

  • Add tests
src/ops.rs Outdated
) -> Box<Op> {
let builder = &mut FlatBufferBuilder::new();
let path =
builder.create_string(std::env::current_exe().unwrap().to_str().unwrap());

This comment has been minimized.

@ry

ry Feb 11, 2019

Collaborator

👍

Show resolved Hide resolved tools/test.py Outdated
Show resolved Hide resolved js/os.ts Outdated
@ry

This comment has been minimized.

Copy link
Collaborator

ry commented Feb 12, 2019

@sh7dm can you make it green?

@sh7dm

This comment has been minimized.

Copy link
Contributor Author

sh7dm commented Feb 12, 2019

@ry will do!

@ry ry force-pushed the sh7dm:add-exec-path branch from f1a8a99 to 9a86f1c Feb 15, 2019

@ry

This comment has been minimized.

Copy link
Collaborator

ry commented Feb 15, 2019

@sh7dm I've cleaned up the code, fixed the test, and changed execPath from a function into a constant string defined at startup.

fix

@ry ry force-pushed the sh7dm:add-exec-path branch from 8e7bd5d to a97f681 Feb 15, 2019

@ry

ry approved these changes Feb 15, 2019

Copy link
Collaborator

ry left a comment

LGTM

@ry ry merged commit 4dc4329 into denoland:master Feb 15, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@sh7dm sh7dm deleted the sh7dm:add-exec-path branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.