Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python2 binary #1764

Closed
wants to merge 2 commits into from

Conversation

3 participants
@flying-sheep
Copy link
Contributor

flying-sheep commented Feb 13, 2019

On e.g. Arch Linux, python symlinks to python3, but the scripts contained in deno are all legacy python.

flying-sheep added some commits Feb 13, 2019

Use python2 binary
On e.g. Arch Linux, `python` symlinks to `python3`, but the scripts contained in deno are all legacy python.
@hayd

This comment has been minimized.

Copy link
Contributor

hayd commented Feb 13, 2019

Are all the v8 build scripts shebang python2? I also thought several called out to python...
Does this branch build on Arch (when python -> python3)?

@flying-sheep

This comment has been minimized.

Copy link
Contributor Author

flying-sheep commented Feb 14, 2019

I started this PR more as a reminder that I’d like to do this.

Yes, depot_tools has a lot of python shebangs that interfere here. this can be patched

The deno package for arch circumvents this by building in an environment where python → python2.

@ry

This comment has been minimized.

Copy link
Collaborator

ry commented Apr 14, 2019

Thanks but doesn't pass CI. Closing.

@ry ry closed this Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.