Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env option to run api #1773

Merged
merged 1 commit into from Feb 15, 2019

Conversation

2 participants
@kt3k
Copy link
Contributor

kt3k commented Feb 14, 2019

This PR adds env option to run API. When env object is specified, the key-value pairs are added to env variables of subprocesses.


This PR addresses this comment, though format.ts itself is now reverted.

@kt3k kt3k force-pushed the kt3k:feature/run-env branch from ed3d19c to 9531085 Feb 14, 2019

const s = new TextDecoder().decode(output);
assertEqual(s, "01234567");
p.close();
});

This comment has been minimized.

@ry

ry Feb 15, 2019

Collaborator

Beautifully done!

@ry

ry approved these changes Feb 15, 2019

Copy link
Collaborator

ry left a comment

LGTM - no comments.

@ry ry merged commit 2241049 into denoland:master Feb 15, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@kt3k kt3k deleted the kt3k:feature/run-env branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.