Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): resource leak in createHmac #18229

Merged
merged 3 commits into from Mar 16, 2023
Merged

fix(ext/node): resource leak in createHmac #18229

merged 3 commits into from Mar 16, 2023

Conversation

littledivy
Copy link
Member

This commit fixes #18140. Verified that test fails on main.

bartlomieju
bartlomieju approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that it fails on main, LGTM. Thanks for fixing this.

@bartlomieju bartlomieju merged commit 1300d61 into denoland:main Mar 16, 2023
10 checks passed
@bartlomieju bartlomieju deleted the createHmac_fix branch March 16, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node: crypto hash functions leak cryptoDigest resources in tests
2 participants
@littledivy @bartlomieju