Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in build #1870

Merged
merged 1 commit into from Mar 2, 2019

Conversation

2 participants
@kt3k
Copy link
Contributor

kt3k commented Mar 2, 2019

This fixes the race condition in build introduced in #1845

compiler_bundle doesn't use gen/gn_args.txt but depends on it because rollup.config.js reads it. This patch adds :write_gn_args to compiler_bundle's dependencies.

example build failure: https://ci.appveyor.com/project/deno/deno/builds/22764022

@ry

ry approved these changes Mar 2, 2019

Copy link
Collaborator

ry left a comment

LGTM

@ry ry merged commit e6c51e6 into denoland:master Mar 2, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@kt3k kt3k deleted the kt3k:feature/fix-race branch Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.