Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write permissions requirement to `op_fetch_module_meta_data`. #1874

Merged
merged 2 commits into from Mar 3, 2019

Conversation

2 participants
@afinch7
Copy link
Contributor

afinch7 commented Mar 3, 2019

I quickly realized that I didn't account for the caching system in #1864. This should fix that and add some requested comments.

@ry

ry approved these changes Mar 3, 2019

Copy link
Collaborator

ry left a comment

LGTM - thanks - I should have caught this on the first review - sorry.

@ry ry merged commit 2af04e6 into denoland:master Mar 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.