Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize version and platform into Deno.build and Deno.version #1879

Merged
merged 2 commits into from Mar 6, 2019

Conversation

3 participants
@kevinkassimo
Copy link
Contributor

kevinkassimo commented Mar 4, 2019

Per #1865
Closes #1865

Deno.version.deno
Deno.version.v8
Deno.version.typescript
Deno.build.arch
Deno.build.os
Deno.build.gnArgs

To make this pass CI, we need to change prettier.ts in deno_std as it is depending on Deno.platform
Deno.platform is now an alias to Deno.build. Should be deprecated in the future.

@kt3k

kt3k approved these changes Mar 4, 2019

Copy link
Contributor

kt3k left a comment

LGTM except CI failure.

@kt3k

This comment has been minimized.

Copy link
Contributor

kt3k commented Mar 4, 2019

//std/prettier/main.ts (and deno --fmt) depends on Deno.platform and that makes CI red.
We need to change them as well at the same time, or keep Deno.platform for a while and remove it later to make CI green.

@ry

This comment has been minimized.

Copy link
Collaborator

ry commented Mar 4, 2019

Can we use a tag for prettier? EG https://deno.land/std@v0.3.0/prettier/main.ts

@kevinkassimo

This comment has been minimized.

Copy link
Contributor Author

kevinkassimo commented Mar 6, 2019

@kt3k There are quite a few other places where deno_std depends on Deno.platform. So yeah I think temporarily keeping Deno.platform for backward compatibility may be fine... We could update deno_std to use the new API once a new release is rolled out

@ry

ry approved these changes Mar 6, 2019

Copy link
Collaborator

ry left a comment

LGTM - thanks @kevinkassimo

@ry ry merged commit de1a10e into denoland:master Mar 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.