Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to TypeScript 3.3 #1908

Merged
merged 1 commit into from Mar 11, 2019

Conversation

3 participants
@kitsonk
Copy link
Contributor

commented Mar 11, 2019

This PR updates Deno to TypeScript 3.3. There was a change in behaviour between 3.2 and 3.3 that was causing some issues in the upgrading. Previously noLib would allow you to specify the libraries you wanted to include in the files and have the references to other libraries to be resolved. That stopped working in 3.3, which the previous behaviour was unintended. Now we have to supply the base library (esnext) in the lib option. The reason we do this is that it ensure that dom and scripthost are not loaded which would potentially allow some features that Deno does not support get past the build process of Deno.

@kevinkassimo

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

(Aside: I like the TypeScript release number)

@kitsonk

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2019

@kevinkassimo yeah, it caused a bit of a controversy though... as of course the next version would have to be 3.3.4000 and not 3.3.4 to make sure the semver worked... oh well... when you have a bit of fun and someone has to ruin it for you

@ry

ry approved these changes Mar 11, 2019

Copy link
Collaborator

left a comment

LGTM - thanks @kitsonk !

@ry ry merged commit 75a500b into denoland:master Mar 11, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.