Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core integration attempt #5 #1938

Merged
merged 2 commits into from Mar 18, 2019

Conversation

3 participants
@ry
Copy link
Collaborator

commented Mar 15, 2019

No description provided.

@ry ry referenced this pull request Mar 15, 2019

Closed

Integrate src/ with core/ #1919

@ry ry force-pushed the ry:core_int5 branch 2 times, most recently from 3a6845a to 455af2d Mar 15, 2019

@ry

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 15, 2019

Current stats. About a 2x speed up over the master branch, but still slower than node_tcp.js

The tail latency (1.4 seconds (!)) suggests there's an obvious bug somewhere. So I'm hopeful.

This branch: target/release/deno tests/http_bench.ts

~/src/deno> third_party/wrk/mac/wrk -d 10 -c 10 http://127.0.0.1:4500/
Running 10s test @ http://127.0.0.1:4500/
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency    23.23ms  114.74ms   1.46s    95.02%
    Req/Sec    18.04k     3.27k   23.84k    75.50%
  359050 requests in 10.00s, 17.46MB read
Requests/sec:  35890.31
Transfer/sec:      1.75MB

vs deno v0.3.3 on tests/http_bench.ts

~/src/deno> third_party/wrk/mac/wrk -d 10 -c 10 http://127.0.0.1:4500/
Running 10s test @ http://127.0.0.1:4500/
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   546.24us  283.72us  13.45ms   96.30%
    Req/Sec     9.41k     1.08k   10.77k    91.58%
  189045 requests in 10.10s, 9.19MB read
Requests/sec:  18717.73
Transfer/sec:      0.91MB

vs node tools/node_tcp.js

~/src/deno> third_party/wrk/mac/wrk -d 10 -c 10 http://127.0.0.1:4544/
Running 10s test @ http://127.0.0.1:4544/
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   246.54us  259.52us  12.56ms   98.22%
    Req/Sec    20.35k     2.47k   27.66k    76.73%
  408850 requests in 10.10s, 19.89MB read
Requests/sec:  40479.68
Transfer/sec:      1.97MB
@hayd

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2019

You might like to run cargo clippy, it raises a few suggestions (not sure whether they are actually perf issues though).

@ry ry force-pushed the ry:core_int5 branch 2 times, most recently from 15d5653 to cce3254 Mar 16, 2019

@ry ry marked this pull request as ready for review Mar 16, 2019

@ry ry force-pushed the ry:core_int5 branch 3 times, most recently from 4b71702 to 356185f Mar 16, 2019

@ry ry requested a review from piscisaureus Mar 17, 2019

@ry ry force-pushed the ry:core_int5 branch 2 times, most recently from efa6166 to 6237312 Mar 17, 2019

@afinch7 afinch7 referenced this pull request Mar 18, 2019

Closed

re-enable arm64 test #1937

Show resolved Hide resolved src/isolate.rs Outdated
Show resolved Hide resolved src/main.rs Outdated

@ry ry force-pushed the ry:core_int5 branch 2 times, most recently from 5314ebd to 75029cf Mar 18, 2019

Integrate //core into existing code base
This disables a few tests which are broken still:
- tests/error_004_missing_module.test
- tests/error_005_missing_dynamic_import.test
- tests/error_006_import_ext_failure.test
- repl_test test_set_timeout
- repl_test test_async_op
- repl_test test_set_timeout_interlaced
- all of permission_prompt_test

@ry ry force-pushed the ry:core_int5 branch from 75029cf to b672c12 Mar 18, 2019

@ry ry merged commit 44773c9 into denoland:master Mar 18, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.