Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add panic handlers again. #2098

Merged
merged 1 commit into from Apr 14, 2019

Conversation

2 participants
@ry
Copy link
Collaborator

commented Apr 11, 2019

The tests were silently failing (again) due to this ill conceived tokio feature.

cc @afinch7 this is happening somewhere in the compiler code - I haven't debugged yet.

Fix silent error, add custom panic handler
This is to work around Tokio's panic recovery feature.
Ref tokio-rs/tokio#495
Ref tokio-rs/tokio#209
Ref #1311
Fixes #2097

@ry ry force-pushed the ry:panic branch from fa937d5 to 853c9d9 Apr 14, 2019

@ry ry requested a review from piscisaureus Apr 14, 2019

@piscisaureus
Copy link
Collaborator

left a comment

LGTM

@ry ry merged commit c7e1f8f into denoland:master Apr 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.