Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix absolute path resolution from remote module #2109

Merged
merged 1 commit into from Apr 13, 2019

Conversation

2 participants
@kt3k
Copy link
Contributor

commented Apr 13, 2019

This PR fixes the absolute path resolution from the remote module.


closes #203


With this change, jspm seems working:

$ cat test.ts 
import React from "https://dev.jspm.io/react";
console.log(React);
$ ./target/debug/deno --reload test.ts 
Compiling file:///Users/kt3k/s/deno/test.ts
Downloading https://dev.jspm.io/react
Downloading https://dev.jspm.io/npm:react@16.8.6/index.dew.js
Downloading https://dev.jspm.io/npm:react@16.8.6/cjs/react.development.dew.js
Downloading https://dev.jspm.io/npm:object-assign@4?dew
Downloading https://dev.jspm.io/npm:prop-types@15/checkPropTypes?dew
Downloading https://dev.jspm.io/npm:react@16.8.6/cjs/react.development.dew.js
Downloading https://dev.jspm.io/npm:object-assign@4?dew
Downloading https://dev.jspm.io/npm:prop-types@15/checkPropTypes?dew
Downloading https://dev.jspm.io/npm:object-assign@4.1.1/index.dew.js
Downloading https://dev.jspm.io/npm:prop-types@15.7.2/checkPropTypes.dew.js
Downloading https://dev.jspm.io/npm:prop-types@15.7.2/lib/ReactPropTypesSecret.dew.js
Downloading https://dev.jspm.io/npm:prop-types@15.7.2/lib/ReactPropTypesSecret.dew.js
Downloading https://dev.jspm.io/react
Downloading https://dev.jspm.io/npm:react@16.8.6/index.dew.js
Downloading https://dev.jspm.io/npm:react@16.8.6/cjs/react.development.dew.js
Downloading https://dev.jspm.io/npm:object-assign@4?dew
Downloading https://dev.jspm.io/npm:object-assign@4.1.1/index.dew.js
Downloading https://dev.jspm.io/npm:prop-types@15/checkPropTypes?dew
Downloading https://dev.jspm.io/npm:prop-types@15.7.2/checkPropTypes.dew.js
Downloading https://dev.jspm.io/npm:prop-types@15.7.2/lib/ReactPropTypesSecret.dew.js
{ Children, createRef, Component, PureComponent, createContext, forwardRef, lazy, memo, useCallback, useContext, useEffect, useImperativeHandle, useDebugValue, useLayoutEffect, useMemo, useReducer, useRef, useState, Fragment, StrictMode, Suspense, createElement, cloneElement, createFactory, isValidElement, version, unstable_ConcurrentMode, unstable_Profiler, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED }
@ry

ry approved these changes Apr 13, 2019

Copy link
Collaborator

left a comment

LGTM

@ry ry merged commit 635ad2a into denoland:master Apr 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@kt3k kt3k deleted the kt3k:feature/absolute-path-from-remote branch Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.