Commits on Apr 16, 2019

1. core/http_bench: support -D flag to enable logging

   

   piscisaureus committed Apr 16, 2019
   Copy the full SHA

   2719631 View commit details

   Browse the repository at this point in the history

2. core: run isolate tests within a task …

   This change is made in preparation for using FuturesUnordered to track
   futures that are spawned by the isolate. FuturesUnordered sets up
   notififications for every future that it finds to be not ready when
   polled, which causes a crash if attempted outside of a task context.

   

   piscisaureus committed Apr 16, 2019
   Copy the full SHA

   dd59522 View commit details

   Browse the repository at this point in the history

3. core: make Isolate use FuturesUnordered to track ops …

   Additionally, instead of polling ops in a loop until none of them are
   ready, the isolate will now yield to the task system after delivering
   the first batch of completed ops to the javascript side.
   
   Although this makes performance a bit worse (about 15% fewer
   requests/second on the 'deno_core_http_bench' benchmark), we feel that
   the advantages are worth it:
   
   * It resolves the extremely high worst-case latency that we were seeing
     on deno_core_http_bench, in particular when using the multi-threaded
     Tokio runtime, which would sometimes exceed a full second.
   
   * Before this patch, the implementation of Isolate::poll() had to loop
     through all sub-futures and poll each one of them, which doesn't scale
     well as the number of futures managed by the isolate goes up. This
     could lead to poor performance when e.g. a server is servicing
     thousands of connected clients.

   

   piscisaureus committed Apr 16, 2019
   Copy the full SHA

   7807afa View commit details

   Browse the repository at this point in the history