Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FileInfo.path #2313

Merged
merged 2 commits into from May 16, 2019

Conversation

2 participants
@ry
Copy link
Collaborator

commented May 8, 2019

Closes #1770

depends on denoland/deno_std#398 in deno_std
depends on #2361

@ry

This comment has been minimized.

Copy link
Collaborator Author

commented May 8, 2019

I will need to remove this from deno_std first:

~/src/deno> ./target/debug/deno fmt badly_formatted.js
Compiling https://raw.githubusercontent.com/denoland/deno_std/master/prettier/main.ts
/Users/rld/Library/Caches/deno/deps/https/raw.githubusercontent.com/denoland/deno_std/master/prettier/main.ts:183:38 - error TS2339: Property 'path' does not exist on type 'FileInfo'.

183     const parser = selectParser(file.path);
                                         ~~~~
/Users/rld/Library/Caches/deno/deps/https/raw.githubusercontent.com/denoland/deno_std/master/prettier/main.ts:185:34 - error TS2339: Property 'path' does not exist on type 'FileInfo'.

185       checks.push(checkFile(file.path, parser, prettierOpts));
                                     ~~~~
/Users/rld/Library/Caches/deno/deps/https/raw.githubusercontent.com/denoland/deno_std/master/prettier/main.ts:211:38 - error TS2339: Property 'path' does not exist on type 'FileInfo'.

211     const parser = selectParser(file.path);
                                         ~~~~
/Users/rld/Library/Caches/deno/deps/https/raw.githubusercontent.com/denoland/deno_std/master/prettier/main.ts:213:36 - error TS2339: Property 'path' does not exist on type 'FileInfo'.

213       formats.push(formatFile(file.path, parser, prettierOpts));
                                       ~~~~

cc @kt3k

@ry ry force-pushed the ry:file_info_path branch from 286474a to 1e86a8a May 15, 2019

@ry ry force-pushed the ry:file_info_path branch from 1e86a8a to 7ce2bd4 May 15, 2019

@ry ry merged commit e02d8bc into denoland:master May 16, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@ry ry referenced this pull request May 16, 2019

Closed

Upgrade deno_std #2361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.