Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - dialTLS #2326

Open
wants to merge 3 commits into
base: master
from

Conversation

@jorsi
Copy link
Contributor

commented May 9, 2019

I would like to write some test cases for this, however I'm pretty lost as to where to start. I looked at dial for TCP, but it uses the listen() api. Another idea would be some sort of python server to dialTLS to.

Let me know what you think, and any future tasks needing to be done.

Thanks.

@jorsi

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

Not sure what test is failing in AppVeyor. I imagine it has something to do with this:

Summary for
undefined

But there doesn't seem to be any tests that failed.

@ry

This comment has been minimized.

Copy link
Collaborator

commented May 23, 2019

@jorsi Any luck with testing? I'd love to land this but we need some way to test it...

@jorsi

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

@ry

This comment has been minimized.

Copy link
Collaborator

commented May 23, 2019

I can push it up to my branch as-is later this evening and perhaps you can take a look at it?

Yes, please

@jorsi

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2019

I can't seem to get past the windows os error (error code 10061: No connection could be made because the target machine actively refused it). This is also happening on all tcp connection tests now, not sure what happened to my machine...

I've tried disabling my firewall settings, all anti-virus features; alas, no avail. I don't think it has anything to do with deno, probably just a bad setup on my machine. Very frustrating.

@jorsi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

@ry ry referenced this pull request Jun 7, 2019
13 of 27 tasks complete
@ry

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

Not yet - very sorry - soon.

WIP dialTLS
Not working still. I'm testing with this:

  ./tools/build.py deno && ./target/debug/deno --allow-net js/net_test.ts

@ry ry force-pushed the jorsi:dialTLS branch from d5c93c9 to 2792e66 Jul 23, 2019

@ry

This comment has been minimized.

Copy link
Collaborator

commented Jul 23, 2019

@jorsi Adding a test to this is still on my TODO. I've rebased and squashed the patch.

@jorsi

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

Been out of commission for awhile since my laptop died on me. Just got a new macbook and started to update to the new changes made. Hopefully will make progress on these tests with my new setup.

@CLAassistant

This comment has been minimized.

Copy link

commented Jul 27, 2019

CLA assistant check
All committers have signed the CLA.

@jorsi jorsi force-pushed the jorsi:dialTLS branch from 805cb23 to ae87fce Jul 27, 2019

@jorsi jorsi force-pushed the jorsi:dialTLS branch from b829959 to a747a04 Jul 28, 2019

@jorsi

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2019

I think this is about as far as I can go on this one. I don't seem to have enough knowledge about ssl/tls and certificates to get this working properly.

I've gotten the build to actually connect to the tls_server now, however there is an issue with self-signed certificates that I can't seem to overcome.

Screen Shot 2019-07-27 at 10 50 25 PM

Other things that I noticed while debugging this that seemed to cause errors:

  • when using localhost as a host (i.e. 'localhost:4443'), resolve_addr() returns an ipv6 address, which the python http server as is can't listen on easily
  • when using an empty host/part string (i.e. ':4443'), the tokiorustls DNSNameRef can't verify a domain name, so I ended up replacing an empty host string with 'localhost' as a fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.