Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edge case in toAsyncIterator #2335

Merged
merged 2 commits into from May 11, 2019

Conversation

2 participants
@bartlomieju
Copy link
Contributor

commented May 11, 2019

This PR fixes issue from #2330, where toAsyncIterator returned no chunks, because reader returned data and EOF in single call.

@ry
Copy link
Collaborator

left a comment

Nice fix!

Show resolved Hide resolved js/io.ts
@ry

ry approved these changes May 11, 2019

Copy link
Collaborator

left a comment

LGTM

@ry ry merged commit 2c6b93e into denoland:master May 11, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bartlomieju bartlomieju deleted the bartlomieju:fix_toAsyncIterator branch May 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.