Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno.core.evalContext() crashes & Deno.core.print() crashes fix #2465

Merged
merged 6 commits into from Jun 7, 2019

Conversation

3 participants
@mhvsa
Copy link
Contributor

commented Jun 6, 2019

Regarding #2457 and #2458

Now it's throwing a catchable error.

> Deno.core.evalContext();

Uncaught TypeError: Invalid Argument
    at <unknown>:1:11
    at evaluate (js/repl.ts:87:34)
    at replLoop (js/repl.ts:145:13)

> Deno.core.print();

Uncaught TypeError: Invalid Argument
    at <unknown>:1:11
    at evaluate (js/repl.ts:87:34)
    at replLoop (js/repl.ts:145:13)

@CLAassistant

This comment has been minimized.

Copy link

commented Jun 6, 2019

CLA assistant check
All committers have signed the CLA.

@mhvsa mhvsa changed the title Deno.core.evalContext() crashes fix Deno.core.evalContext() crashes & Deno.core.print() crashes fix Jun 6, 2019

mhvsa and others added some commits Jun 6, 2019

@ry

ry approved these changes Jun 7, 2019

Copy link
Collaborator

left a comment

LGTM - thanks!

@ry ry merged commit 9bea576 into denoland:master Jun 7, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.