Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set setTimeout callback's `this` to window object #2497

Merged
merged 1 commit into from Jun 11, 2019

Conversation

2 participants
@justjavac
Copy link
Contributor

commented Jun 11, 2019

ref: https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/setTimeout#Explanation

Note: The default this value of a setTimeout callback will still be the window object, and not undefined, even in strict mode.

@justjavac justjavac changed the title set `setTimeout` callback's `this` to window object set setTimeout callback's `this` to window object Jun 11, 2019

@ry

ry approved these changes Jun 11, 2019

Copy link
Collaborator

left a comment

LGTM

@ry ry merged commit cb58162 into denoland:master Jun 11, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@justjavac justjavac deleted the justjavac:settimeout branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.