Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLSearchParams with Custom [Symbol.iterator] #2512

Merged
merged 2 commits into from Jun 14, 2019

Conversation

2 participants
@justjavac
Copy link
Contributor

commented Jun 13, 2019

js/util.ts Outdated
// Returns whether o is iterable.
// @internal
// eslint-disable-next-line @typescript-eslint/no-explicit-any
export function isIterable(obj: any): obj is Iterable<any> {

This comment has been minimized.

Copy link
@ry

ry Jun 13, 2019

Collaborator

unknown instead of any?

I think @internal is not needed here as this file isn't exported from js/globals.ts

This comment has been minimized.

Copy link
@justjavac

justjavac Jun 14, 2019

Author Contributor

generics is a better choice

@ry

ry approved these changes Jun 14, 2019

Copy link
Collaborator

left a comment

LGTM

@ry ry merged commit 52448f3 into denoland:master Jun 14, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@justjavac justjavac deleted the justjavac:urlsearchparams-custom-iterator branch Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.