Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deno install command #2522

Merged
merged 2 commits into from Jun 14, 2019

Conversation

2 participants
@bartlomieju
Copy link
Contributor

commented Jun 14, 2019

Following denoland/deno_std#489 I added deno install subcommand.

Note that this PR is only a proof-of-concept and shouldn't be merge until installer has stabilized and tagged URL can be used.

@ry

This comment has been minimized.

Copy link
Collaborator

commented Jun 14, 2019

I'm fine with landing it sooner rather than later. I think we'll get more feedback if it goes out in the release. You can tag based on commit.

@bartlomieju bartlomieju changed the title feat: add deno install command [do not merge] feat: add deno install command Jun 14, 2019

@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

@ry you got it

@ry
Copy link
Collaborator

left a comment

LGTM. Let’s try it out

@ry

ry approved these changes Jun 14, 2019

@ry ry merged commit 3dff147 into denoland:master Jun 14, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bartlomieju bartlomieju deleted the bartlomieju:feat-deno_install_command branch Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.