Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dispatch take 2 #2533

Merged
merged 1 commit into from Jun 18, 2019

Conversation

2 participants
@afinch7
Copy link
Contributor

commented Jun 15, 2019

Removed most of the changes to core from #2452, but kept the improvements to cli dispatch.

  • cli dispatches now return a Result<Op, DenoError> value allowing for use of the try operator and returning non-futures in the form of Op::Sync
  • seamless handling of Op::Sync responses to async calls.
  • some cleanups in //js/dispatch.js

Since i'm not trying to internalize promise_id anymore, this shouldn't affect performance.

@afinch7 afinch7 changed the title Refactor dispatch Refactor dispatch take 2 Jun 15, 2019

@ry

ry approved these changes Jun 18, 2019

Copy link
Collaborator

left a comment

LGTM

@ry ry merged commit 76d51b0 into denoland:master Jun 18, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.