Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wasm compilation silent failure #2548

Merged
merged 1 commit into from Jun 20, 2019

Conversation

2 participants
@ry
Copy link
Collaborator

commented Jun 19, 2019

Fixes #2544

Testing with

./tools/build.py libdeno_test && ./target/debug/libdeno_test --gtest_filter=LibDenoTest.WasmInstantiate

@ry ry changed the title Fix async wasm compilation WIP Fix async wasm compilation Jun 19, 2019

@ry ry force-pushed the ry:wasm_add branch 2 times, most recently from 69423f6 to 086db58 Jun 19, 2019

@ry ry changed the title WIP Fix async wasm compilation Fix wasm compilation silent failure Jun 19, 2019

@ry ry force-pushed the ry:wasm_add branch from 086db58 to 0898cfa Jun 19, 2019

Fix silent failure of WebAssembly.instantiate()
By making WASM compilation synchronous. We'll have to do more work to
make it properly async.

@ry ry force-pushed the ry:wasm_add branch from 0898cfa to 9fc71d4 Jun 19, 2019

@ry ry requested a review from piscisaureus Jun 19, 2019

@piscisaureus
Copy link
Collaborator

left a comment

Lgtm

@ry ry merged commit f2c50fa into denoland:master Jun 20, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@ry ry referenced this pull request Jun 20, 2019

Closed

WASM Support #1325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.