Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update installer #2551

Merged
merged 5 commits into from Jun 20, 2019

Conversation

2 participants
@bartlomieju
Copy link
Contributor

commented Jun 20, 2019

Updates installer to latest version denoland/deno_std@b13441f

Closes #2534

@@ -350,7 +350,14 @@ Demonstrates breaking the input up by space delimiter instead of by lines:
.long_about(
"Automatically downloads deno_installer dependencies on first run.
deno install file_server https://deno.land/std/http/file_server.ts --allow-net --allow-read",
deno install file_server https://deno.land/std/http/file_server.ts --allow-net --allow-read
deno install -d /usr/local/bin file_server https://deno.land/std/http/file_server.ts --allow-net --allow-read",

This comment has been minimized.

Copy link
@ry

ry Jun 20, 2019

Collaborator

How about another example that has no flags:

deno install colors https://deno.land/std/examples/colors.ts

This comment has been minimized.

Copy link
@ry

ry Jun 20, 2019

Collaborator

Can you mention here that the default install directory is $HOME/.deno/bin and that people need to manually add it to their path?

@ry

ry approved these changes Jun 20, 2019

Copy link
Collaborator

left a comment

LGTM

@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

Please wait, I'm writing up manual ATM

@bartlomieju

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

@ry PTAL at the manual

Show resolved Hide resolved website/manual.md Outdated
Show resolved Hide resolved website/manual.md Outdated
Show resolved Hide resolved website/manual.md Outdated
Show resolved Hide resolved website/manual.md Outdated

@ry ry merged commit 77a00ae into denoland:master Jun 20, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bartlomieju bartlomieju deleted the bartlomieju:feat-update_installer branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.