Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch: make response.body async iterable #2563

Merged
merged 1 commit into from Jun 22, 2019

Conversation

2 participants
@kt3k
Copy link
Contributor

commented Jun 22, 2019

This PR makes response.body of fetch async iterable.

fixes #2520

@kt3k kt3k force-pushed the kt3k:feature/body-async-iterator branch from bce6c78 to 11a2161 Jun 22, 2019

@ry

ry approved these changes Jun 22, 2019

Copy link
Collaborator

left a comment

LGTM

total += chunk.length;
}

assertEquals(total, Number(headers.get("Content-Length")));

This comment has been minimized.

Copy link
@ry

ry Jun 22, 2019

Collaborator

👍

@ry ry merged commit 988bcbb into denoland:master Jun 22, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@kt3k kt3k deleted the kt3k:feature/body-async-iterator branch Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.