Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot creator in Rust #2617

Merged
merged 2 commits into from Jul 8, 2019

Conversation

3 participants
@ry
Copy link
Collaborator

commented Jul 6, 2019

@ry ry force-pushed the ry:feat-snapshot_creator_rust branch from aa2f271 to 0a2a24c Jul 7, 2019

@bartlomieju

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2019

This looks very good to me, I have a couple of questions though:

  • I guess adding Rust as dependency for libdeno is no longer a concern because snapshot creator is now core/ concept?
  • how about renaming Snapshot1 and Snapshot2 from core/libdeno.rs while you're at it?
@ry

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 7, 2019

I guess adding Rust as dependency for libdeno is no longer a concern because snapshot creator is now core/ concept?

I changed the libdeno tests to construct its snapshot at runtime rather than compile time, to simplify the GN deps. This allows removing core/libdeno/snapshot_creator.cc and other code.

how about renaming Snapshot1 and Snapshot2 from core/libdeno.rs while you're at it?

This is another refactor that should be done separately. There's more to it than just renaming.

@ry ry force-pushed the ry:feat-snapshot_creator_rust branch from 1dd94e9 to 49961d3 Jul 7, 2019

@piscisaureus piscisaureus force-pushed the ry:feat-snapshot_creator_rust branch from 556dfde to 919c5a1 Jul 7, 2019

Show resolved Hide resolved tools/gn.rs Outdated

@piscisaureus piscisaureus force-pushed the ry:feat-snapshot_creator_rust branch 2 times, most recently from c39d905 to f60518e Jul 7, 2019

@ry ry force-pushed the ry:feat-snapshot_creator_rust branch 2 times, most recently from d2f08a5 to 1e28f41 Jul 8, 2019

Pass env vars through in build_extra/rust/run.py
This fixes an appveyor issue that arrises when implementing
snapshot_creator in Rust.

@ry ry force-pushed the ry:feat-snapshot_creator_rust branch 2 times, most recently from 18f3915 to 4239f8b Jul 8, 2019

Show resolved Hide resolved core/snapshot_creator.rs Outdated
Show resolved Hide resolved core/snapshot_creator.rs Outdated
@piscisaureus
Copy link
Collaborator

left a comment

👍

@ry ry force-pushed the ry:feat-snapshot_creator_rust branch from 9450635 to f74bc3f Jul 8, 2019

@ry ry merged commit d641782 into denoland:master Jul 8, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.